Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: changed the consumption how to import required styles #2612

Merged
merged 24 commits into from
May 30, 2024
Merged

feat: changed the consumption how to import required styles #2612

merged 24 commits into from
May 30, 2024

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented May 6, 2024 •
edited
Loading

Proposed changes

  • test how to import only required styles for single component
  • split big styling files to have more optional imports
  • write new documentation, how to use styles
  • add optional classes to 42 files as the full solution

closes #2130
closes #2131

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@github-actions github-actions bot added 🏗foundations Changes inside foundations folder 🏘components Changes inside components folder labels May 6, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 6, 2024

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/feat-style-consumption

@github-actions github-actions bot added the 📺showcases Changes to 1-n showcases label May 8, 2024
@nmerget
chore: add extra classes for foundation styling
028e40a 
docs: improve documentation for foundations and components
@github-actions github-actions bot added the 📕documentation Improvements or additions to documentation label May 8, 2024
@nmerget nmerget self-assigned this May 8, 2024
@nmerget nmerget marked this pull request as ready for review May 10, 2024 08:31
@nmerget nmerget requested review from dkolba and annsch as code owners May 10, 2024 08:31
@nmerget nmerget requested a review from mfranzke May 10, 2024 08:31
@nmerget nmerget enabled auto-merge (squash) May 10, 2024 08:32
@nmerget nmerget assigned mfranzke and unassigned nmerget May 10, 2024
@nmerget nmerget requested a review from mfranzke May 14, 2024 09:50
@nmerget nmerget linked an issue May 24, 2024 that may be closed by this pull request
CSS: Provide our styles in isolation complementary #1155
Closed
@mfranzke mfranzke removed their assignment May 29, 2024
@nmerget nmerget merged commit b209a2a into main May 30, 2024
37 checks passed
@nmerget nmerget deleted the feat-style-consumption branch May 30, 2024 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfranzke mfranzke mfranzke left review comments

@bruno-sch bruno-sch bruno-sch approved these changes

@dkolba dkolba Awaiting requested review from dkolba

@annsch annsch Awaiting requested review from annsch annsch is a code owner

Assignees
No one assigned
Labels
🏘components Changes inside components folder 📕documentation Improvements or additions to documentation 🏗foundations Changes inside foundations folder 📺showcases Changes to 1-n showcases
Projects
None yet
Milestone
No milestone
3 participants
@nmerget @mfranzke @bruno-sch